Page 4 of 4

Re: 0.5.8.5 Released

Posted: Wed Mar 05, 2008 11:04 pm
by Stedevil
andar wrote:I committed something that might help with the fastresume saving. Give SVN a shot if you want to test it.
I restarted the SVN version 5-6 times, no problems now. Even when removing 1-2 .fastresumes it doesnt "lose" any of the others and after checking the removed ones are put back ready for next restart. Job well done! :) 0.5.8.6 ASAP?

PS for 0.5.8.7+, what about remaking the checking order? Eg right now if a file doesnt have a .fastresume and begins to be checked, other files WITH a .fastresume later in the "queue" still are not put into seeding/leaching mode before the one missing a .fastresume is checked. I think remaking the queue-code to always use the following order would be a nice enhancement.

1) Files with .fastresume
2) Files without .fastresume starting with NEWEST torrent (as opposed to the current oldest?)

Would make the most sense IMO. :)

Re: 0.5.8.5 Released

Posted: Thu Mar 06, 2008 12:25 am
by andar
Stedevil wrote:
andar wrote:I committed something that might help with the fastresume saving. Give SVN a shot if you want to test it.
I restarted the SVN version 5-6 times, no problems now. Even when removing 1-2 .fastresumes it doesnt "lose" any of the others and after checking the removed ones are put back ready for next restart. Job well done! :) 0.5.8.6 ASAP?

PS for 0.5.8.7+, what about remaking the checking order? Eg right now if a file doesnt have a .fastresume and begins to be checked, other files WITH a .fastresume later in the "queue" still are not put into seeding/leaching mode before the one missing a .fastresume is checked. I think remaking the queue-code to always use the following order would be a nice enhancement.

1) Files with .fastresume
2) Files without .fastresume starting with NEWEST torrent (as opposed to the current oldest?)

Would make the most sense IMO. :)
Actually I have been thinking about doing this for a long time and it's actually something I will be doing for 0.6. I was looking at 0.5's code last night and considered making this change, but I am hesistant to change too much in 0.5 because I simply hate supporting it. Plus, it seems like every time I fix something in 0.5 it breaks 2 other things. ;)

I will consider adding it into 0.5 as long as I get some testers!

Re: 0.5.8.5 Released

Posted: Thu Mar 06, 2008 12:43 am
by Stedevil
andar wrote: I will consider adding it into 0.5 as long as I get some testers!
Well, if you make it, I'll test it. But if a stable 0.6 is not too far away in the future, perhaps it's better to concentrate the efforts on that code instead? :)
I'll trust your judgement on this since I dont have a clue about how much time adding this would take. :mrgreen:

Re: 0.5.8.5 Released

Posted: Thu Mar 06, 2008 1:03 am
by andar
Stedevil wrote:
andar wrote: I will consider adding it into 0.5 as long as I get some testers!
Well, if you make it, I'll test it. But if a stable 0.6 is not too far away in the future, perhaps it's better to concentrate the efforts on that code instead? :)
I'll trust your judgement on this since I dont have a clue about how much time adding this would take. :mrgreen:
It's actually fairly trivial. I'll commit the code tonight once I get off work.

Re: 0.5.8.5 Released

Posted: Thu Mar 06, 2008 11:46 am
by waltherbans
i uninstalled deluge and deleted .config/deluge/ and installed svn 2916 (on ubuntu 8.04 i386) to test the solution of the .fastresume-problem.
starting deluge results in a crash:

Code: Select all

Traceback (most recent call last):
  File "/usr/bin/deluge", line 45, in <module>
    import deluge.core
  File "/usr/lib/python2.5/site-packages/deluge/core.py", line 278
    if os.path.exists(torrent.filename + ".fastresume")
                                                      ^
SyntaxError: invalid syntax
what's wrong?

Re: 0.5.8.5 Released

Posted: Thu Mar 06, 2008 1:07 pm
by markybob
waltherbans wrote:i uninstalled deluge and deleted .config/deluge/ and installed svn 2916 (on ubuntu 8.04 i386) to test the solution of the .fastresume-problem.
starting deluge results in a crash:

Code: Select all

Traceback (most recent call last):
  File "/usr/bin/deluge", line 45, in <module>
    import deluge.core
  File "/usr/lib/python2.5/site-packages/deluge/core.py", line 278
    if os.path.exists(torrent.filename + ".fastresume")
                                                      ^
SyntaxError: invalid syntax
what's wrong?
andar broke it :P i just fixed it, so svn up again and you should be fine

Re: 0.5.8.5 Released

Posted: Thu Mar 06, 2008 1:55 pm
by waltherbans
markybob wrote: i just fixed it, so svn up again and you should be fine
thanks!
andar wrote:I committed something that might help with the fastresume saving. Give SVN a shot if you want to test it.
On my machine svn 2920 produced .fastresume-files for each torrent, but after proper shutdown and restart of deluge "lots" of them were gone. on every restart deluge kills some .fastresume-files and recreates them when it's gui is started. i don't/can't see any systematic deletin. all torrents are completely on my hd and all torrent-files are created with deluge's torrent-creator. :(

Re: 0.5.8.5 Released

Posted: Thu Mar 06, 2008 5:28 pm
by Stedevil
waltherbans wrote: On my machine svn 2920 produced .fastresume-files for each torrent, but after proper shutdown and restart of deluge "lots" of them were gone. on every restart deluge kills some .fastresume-files and recreates them when it's gui is started. i don't/can't see any systematic deletin. all torrents are completely on my hd and all torrent-files are created with deluge's torrent-creator. :(
Hmm, I'm on Ubuntu 7.10 with Revision: 2913
Back down to the 2913 version to see if that works for you, if that works then something of the new stuff broke. If it doesn't work they you either have a Hardy Heron beta problem or found yet another situation where the .fastresume doesnt work.

PS I assume you didnt forget to do a make install and are sure you are running the SVN version.