FlexRSS plugin

[daddy]

Ah, yes it is. You aren't telling FlexRSS where to get the series and episode information from. Instead of making the pattern "Chuck", try making it "Chuck.S%sE%e".

For more information, see the patterns section of the documentation. Let me know if you have any more problems

[Comm]

Wonderful, thank you so much! It now works great!

[johnnyg]

I think FlexRSS requires the filter for TV Shows to have %s & %e, even if you're not restricting the history?

I say this because all of my TV Show filters worked perfectly the first week when I created them but then the next week although they would match an RSS item they wouldn't download it. At first I thought it was a bug and removed and re-added the filter, causing the filter to download the matched show. However then seeing it started happening with all my filters I gathered that seeing it didn't have any season or episode information it would only allow the filter to match once (hence why the previous trick worked). By adding %s and %e to my regexp it would then consider each episode different and hence worked.

if this is the case, you should probably put a little blurb in your documentation about it.

Also, any chance of having global filters? i.e. a filter which is applied to all your other filters; it would be very useful in limiting format/quality types.

[daddy]

if this is the case, you should probably put a little blurb in your documentation about it.

It is the case for the TV Show type. There is a little blurb buried in the patterns section that says, "Any named pattern can be omitted, but will default to 0, so if you don't include any only the first item will be downloaded." It should probably be featured a bit more prominently, though. Feel free to edit the documentation if you can figure out where to fit it in--I suck at writing guides, and could use all the help I can get

Also, any chance of having global filters? i.e. a filter which is applied to all your other filters; it would be very useful in limiting format/quality types.

Hmm... I'm not sure how I would implement that. I don't like the idea of a dumb filter that just searches for, e.g., HR HDTV, and blocks the DL if it matches (or doesn't). Maybe look for named patterns for group, source (hmm... can't use %s), and format, then test them against a list of rules somewhere (new tab?)? I'll have to think about this. If you have any thoughts, let me know.

[johnnyg]

There is a little blurb buried in the patterns section that says, "Any named pattern can be omitted, but will default to 0, so if you don't include any only the first item will be downloaded." It should probably be featured a bit more prominently, though. Feel free to edit the documentation if you can figure out where to fit it in--I suck at writing guides, and could use all the help I can get

ah yes, I see it now. Making that sentence bold should make it obvious enough to people browsing through your documentation.

Hmm... I'm not sure how I would implement that. I don't like the idea of a dumb filter that just searches for, e.g., HR HDTV, and blocks the DL if it matches (or doesn't). Maybe look for named patterns for group, source (hmm... can't use %s), and format, then test them against a list of rules somewhere (new tab?)? I'll have to think about this. If you have any thoughts, let me know.

I don't like the idea of a dumb filter either.

How about creating a named pattern for quality (maybe with an alias like %q) which the user defines and then having a section "Quality Restriction" (like history restriction) for each filter where the user can restrict the quality of the matched file.

Then all you would need to do is have a separate tab with a "Set All/Generic/TV Show/TV Show (dated) to following quality restriction" which would basically iterate through the chosen set and set the appropriate quality for each filter.
Alternatively you could just have a "Set this quality restriction to all/this type(s) of filter" button on the filter settings which does the same thing.

Either way, the user would only have to set the quality restriction once and have it applied globally but implementation wise, the matching would still be done individually (i.e. no dumb filter).

That's the only thought I've had on it so far. What do you think?

[zcat]

attached is a small patch that fixes a non-critical bug I noticed in 0.2.3 while browsing through the code -- namely that the feeds_counter was being used where filters_counter should have been. After the fix is applied the feeds and filters id's increment *independently*, as they were apparently intended to be, and both are written to the config. Note that it was necessary to bump the config version from 5 to 6 in order to set the filters_counters to the feeds_counter + 1, else it would have been reset to 0 for old configs, resulting in duplicate filter id's.

Fedora's version of deluge was just recently updated (0.5.7), and it included FlexRSS, which is the main reason why I'm finally considering switching from the java-pig Azureus + powerful RSSFeed Scanner, to Deluge + FlexRSS (SimpleRSS didn't cut it). I've got quite a huge list of filters already, so I'm looking to hack a quick & dirty converter (from java serialized to python pickle'd)...

One simple feature I'd like to see: right click a feed item -> copy to clipboard

(Also, I noticed that the "Thru" History Restriction isn't implemented yet?)

[zcat]

patch attached to add a "Copy link URL to clipboard" entry to the rightclick menu on the feed items list. I use this very often with Azureus' rssfeed scanner in order to quickly grab a link to share...

[daddy]

attached is a small patch that fixes a non-critical ...

Sounds good. I'll take a look at your patches within the next 48 hours and pass them along to markybob if he hasn't already included them. I know the quality of the current code is ****, and I'm really sorry about that. I'm leaning towards a re-write.

Fedora's version of deluge was just recently updated (0.5.7), and it included FlexRSS, which is the main reason why I'm finally considering switching from the java-pig Azureus + powerful RSSFeed Scanner, to Deluge + FlexRSS (SimpleRSS didn't cut it). I've got quite a huge list of filters already, so I'm looking to hack a quick & dirty converter (from java serialized to python pickle'd)...

That would be cool if you can find a way. I'm really thinking about that re-write, which would get rid of the pickle'd python cruft (xml or sqlite, probably), but it seems unserializing the java would be the hard part. Glad you're liking FlexRSS, in spite of seeing the source code

(Also, I noticed that the "Thru" History Restriction isn't implemented yet?)

If that's true, "oops". Thanks for bringing it up.

patch attached to add a "Copy link URL to clipboard" entry to the rightclick menu on the feed items list. I use this very often with Azureus' rssfeed scanner in order to quickly grab a link to share...

Great idea, thanks for the patch

[daddy]

Okay, I think I'll elaborate on my re-write thoughts.

I really wrote this plugin as much to learn python as anything else, and the code isn't of the highest quality. It has grown substantially from my original ideas, and is really just a bunch of hacks on top of my original idea. It really needs a re-write, especially if I (or other people) am going to continue to add features. So, skipping over the stuff people who haven't read the code don't care about, here are a few thoughts on what I want a new version to be like:

• The save buttons need to go. They were okay when the plugin was simpler, but not anymore.
• The stuff I was talking about with johhnyg--support for group, encoding, and source info. I'm not sure if this should be on a per-filter or global basis. Thoughts, anyone?
• Somewhat related to above, but propers should be supported (configurably).
• History editor. I blew this off before because I was only thinking about removing past history, but there should be a way to tell FlexRSS "don't bother with episode n, I caught it on TV already"
• XML or SQLite instead of pickle'd python (leaning towards sqlite. Thoughts?). The current way of doing things just isn't robust to changes.
• Possibly have a beginner mode. Until recently I would have said no way, but with SimpleRSS dropped... well, it may be easier to just make a friendlier version than have beginners constantly complaining and demanding support.

So, before I get started, what do you people want? I don't want to be re-writing this thing every few months (nor am I willing to), so speak up now. Is there something that pisses you off about FlexRSS? Is there something you miss about ______?

[MoJo]

Hey I already like the current setup, but if your gonna rewrite it and make it easier to make it extensible ... then by all means go for it. Just along the way of coding ... leave tidbits of comments to make it way easier to add new functionality. About using SQLite, would that mean also shipping the plugin with the SQLite binary? If so maybe going an XML route would be easier ... it would be easier to maintain and it would mean a Database isn't running in the background however lite it is.