installer doesn't populate displayversion in the registry

[jpph]

Hello,
There is an issue with version not populated in the registry. The consequence is that each time we do Winget update all there is a message saying there is a package with no version information. If we use the flag to it ignore this, deluge is needlessly updated each time we run the command...
I have issued bug report to Winget , they are saying they can do nothing, the install package need to be modified by you...
https://github.com/microsoft/winget-pkgs/issues/166120

I tried to use the Trac system but can not create account so if someone would like to create a ticket for me that would be nice

Thank you for your great software, working nicely on my windows arm snapdragon laptop

[mhertz]

Thanks, I'll look into it one of these days and make ticket or something. I briefly checked the nsis script and it has sections for displayversion regkey, but a really quick test install in my win10 wm showed not that key set, as you say, unless I checked little to quick, but as said will figure out the issue later and report back, unless beaten by other good folk around here. Thanks for reporting

[jpph]

Thank you!!!

[mhertz]

Much welcome buddy!

Anyway, I stupidly looked at the develop branch codebase, instead of the 2.1.1 release tag, and sure enough, the good DjLegolas already fixed this issue and added said missing DisplayVersion reg key here, so the issue is already fixed in fact, in current develop branch, and so will be fixed when next release of deluge comes out.

Deluge in v2.1.1 actually sets DisplayName reg-key, with the version appended to the tring, but not as an actual DisplayVersion key specifically, as you found, and now fixed by DjLegolas.

I see the regkeys are getting written into the 32 bit area, for 64 bit apps, like if it was an 32 bit app installed onto 64 bit OS, i.e. 'HKLM/Software/Wov6432Node/Microsoft/Windows/Uninstall/' - it does that because the NSIS script needs to be specifically directed to do otherwise, e.g. using 'SetRegView 64' added to the x64 initial check, already differencing $programfiles for 32/64 locations, so might make a PR for that later, but should not really be important, as is normal to check there also, e.g. with winget etc.

So, as said, already fixed for next version, many thanks to DjLegolas!

Until next version, then if wanted can quickly add the missing key yourself, for winget usage etc, through e.g. in an elevated cmd-prompt(win+r > cmd > ctrl+shift+return) running:

Code: Select all

reg add HKLM\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\Deluge /v DisplayVersion /d 2.1.1 /f

(Might as well add it to the same location as the other two values made by installer, so gets removed in the uninstall process anyway, also now with current version, hence the wow6432node location used above)