*OLD-THREAD - SEE NEW* [Unofficial] Deluge 2.0.x installer

[waffles]

Thanks for your hard work.

[mhertz]

Thank you waffles for your kind post, appreciate that mate!

[mhertz]

I found out the deluge 1.x windows theme was based on ANewStart theme, I read Cas state in 8 year old posting. I found it was updated for gtk3, but haden't been updated in many years since that. Anyway, I hoped to replicate atleast somewhat the old familiar-to-folks look of deluge 1.x into deluge 2.x with it, but unfortunetly it looked really strange and clearly there was something wrong as you could barely see the different parts of the UI or text, so not compatible with newer gtk3's seemingly.

For people that don't wanna enable GTK_CSD=0 because of risk of performance degredation, but would still like a native looking titlebar with native looking buttons, then I again looked for win10 native looking gtk3 theme's, as I have before too, but decided to give it another shoot again. I retested the win10 native looking options and posted screenshoot's below. They aren't anything special, and some are extremely whitish looking, but anyway, I just wanted people to have some optons to choose from. Also, the 'Windows 10 GTK' theme, doesn't even have windows native titlebar buttons, but just included it anyway, as one of the better of the bunch imho, if can live with standard adwaita style buttons(gtk3 default), that is if not already using GTK_CSD=0 that is.

I also was thinking about taking some of the png's for the titlebar buttons from one of these theme's that have such available as assets in there theme folder, and to rename them and overwrite the ones in Mantis-Dark theme, which have very strange and out of place looking buttons, in red, but it's just not that easy because that theme have many variations of each button from variying states and e.g. hoovering etc, whereas the buttons from the win10 theme's just have a few files for each button, so have to match up them right and copy them over as other names, and make sure hoovering works, backdropping and whatnot etc, so pretty time-consuming, and sometimes I think why bother, when GTK_CSD=0 already fixes that issue fine already, and who's to say that the performance degredation reported also affects deluge too, as was just reported using some other gtk3 apps, by a few people, using benchmark tools for displaying the disreprency, which seemingly is a windows only problem of gtk3 with regards to that GTK_CSD=0 option. Personally, if it was me, then I wouldn't take the chance with that option, which is why I don't enable it in installers as per default already, but as said, I neither couldn't care less about UI looks really, so up to you, and if not noticing any issues yourself with said option, then why not keep using it.

Here are the shoots, not neccesarilly in same order as the links posted, so check screenshot filename and match to link, if interrested. Follow link in one of my previous posts for instructions on how to change theme. Note the folder you move over under 'data\share\themes' should always be a folder with a gtk-3.x folder directly inside(among other stuff), and not further down the folder-hierarchy, as sometimes you need to move one of the subfolders instead of main folder when unzipping the downloaded archive. The only thing I missed in my previously posted instructions, is that the theme name you specify under 'data\etc\gtk-3.0\settings.ini', is simply always the name of the folder of said theme, that you downloaded and moved over under 'data\share\themes'. The only exception, is regarding built-in themes coming with gtk3 already by default i.e. win32, adwaita, and adwaita-dark, which is why there aren't any such folders named like that there, as built-in, and so can still specify to use them in settings.ini as per my previous instructions. The themes you add yourself, you can simply also rename the folder names to have better names or just shorter names if wanted, and just specify new renamed name into the settings.ini file previously mentioned.

(Untitled.png) Redstone: https://github.com/B00merang-Project/Wi ... ve/3.2.zip
(Untitled2.png) Redstone-dark: https://github.com/B00merang-Project/Wi ... 2-dark.zip
(Untitled3.png) Windows 10 Light Theme: https://www.gnome-look.org/p/1216281/st ... ze=3985361
(Untitled4.png) Windows 10 GTK: https://www.gnome-look.org/p/1013580/st ... size=78722

The board only allowed me attaching 3 pics, so the fourth is a link for pic uploaded elsewhere, for Untitled4.png, which needs clicking on to see:
https://imgur.com/dKw08xK

[PhiliP]

Is there a simple (folder or/and script to modify) way to just change the icons and their size in the toolbar, and maybe the font size of the whole interface (getting old eyes) ?

I've search a little bit, found this file but had no effect on the size...

[mhertz]

I know very little about theme'ing and such, so cannot really be of much help sorry. I tried before fixing a field hard to read in win32 theme, but didn't even succede in that lol

That file you're looking at, is only working on gtk2, and this is gtk3 here in deluge2. The two built-in themes, adwaita and win32, doesn't have any files to edit in the installation, as built into gtk. I can supply you a zip of the folder/files needed from git, so you can take a look yourself and see if you can make changes you want, if you tell me if you want adwaita or win32 or both. Then if adding such folder with same name as theme and edited theme files in it, then those changed files will be loaded when said theme is defined, i.e. a win32 or adwaita folder added under 'data\share\themes'. I used to do that previously to add a bugfix from git to win32 theme, but is included now so no need anymore.

We are at gtk 3.24 currently, and before gtk 3.10 there where nice options for setting toolbar-size and other stuff, but got removed in later releases, and then was solely up to the devs to configure such themselves. There is an option not removed for setting font and size, in 'data\etc\gtk3.0\settings.ini, named 'gtk-font-name', also 'gtk-font-size', but you can also set size from the first option by using both name and size. You don't need double-quotes in gtk3 for values with spaces in between btw. Howeer, in my testings, I couldn't change font and size from those settings. I'm guessing that they only work when using a theme which doesn't already state which font and size to use, which probably overrides the settings.ini, since it didn't work in my tests, or else i'm just doing something wrong though, but am simply following gtk3 reference manual, and various examples of values online for other gtk3 apps. There where suggested e.g. 'gtk-font-name=Arial 14' but didn't change anything. The default value is 'Sans 10' for that value in gtk3. The win32 theme uses in there CSS for font and size I could see: 'Segoe UI 9', so as said, probably overrides settings.ini with app specific value, as settings.ini is for general values for all gtk apps supporting it.

The toolbar size and button size also is now only defined in those CSS files, I believe as setting min width/height of buttons or toolbar, and 16/16 is small and 24/24 is normal(big), but again I had a hard time figuring it out, though granted only spent little time on it.

If you wanna see first if you think you will be able to change stuff then here are some links to said CSS files so you can see the syntax:

win32 theme files:

https://github.com/GNOME/gtk/tree/gtk-3 ... heme/win32

Adwaita theme files:

More than this, but main file I believe: https://github.com/GNOME/gtk/blob/gtk-3 ... tained.css (gtk.css just calls this one and nothing else, but there are other files called from this though).

Toolbar-button changes usually on gtk3 apps needs you to download a gtk3 icon theme, and place folder of that under 'data\share\icons' and add the new theme under 'data\etc\gtk-3.0\settings.ini' as 'gtk-icon-theme-name=xxxxxx', where xxxxx is name of folder added before with the icon theme. Never messed with that myself, especially as so few buttons. Atleast Cas stated many years ago that it was default gtk icons, and should install new icon theme if wanted it changed, but I don't know if things have changed since.Actually I just skimmed through the UI code and it seems deluge hardcodes some icon names, and they aren't included(there are some included, like the droplet, flags and icons from lowest small bar etc, but not any from the main toolbar) and looking the names up suggest they are from gnome icon set. Cas develops on ubuntu I believe, which maybe uses gnome icon set I dunno, but would guess it. Anyway, I don't really have dwelled into that, so don't really know honestly much about it. By default adwaita icon set is used when not having defined an icon set.

Sorry couldn't help you with this unfortunetly.

I will mess little around with the win32 theme when time/motivation for it, as e.g. still wan't that almost unreadable line fixed(white text on light-grey background), and then at same time can look at if can make toolbar bigger, and as said the font already is defined there as Segoe UI 9, so I guess a simple changing of that value(9) would up the font size seemingly(and font name/type changed if wanted). I'll post if find something out, but will probably not be that quickly honestly.

Edit: OK, I fixed the issue of hard to read unfocused selected items, which was an issue in win32 theme, but not in adwaita and other themes, so will upload new fixed installers probably sometime tomorrow.

@PhilliP, if you use win32 theme as per default in these installers, then when I upload new installers, you can change font size or/and type in file 'data\share\themes\win32x\gtk-3.0\gtk-win32-base.css' on line 25 and 26, for type and size, e.g. change line 26 of "font-size: 9pt;" to instead "font-size: 11pt;". Still haven't found out about how make toolbar bigger yet though. Well, I can make the bar bigger, but not the icons themselves yet, so there is just extra empty padding over and under, which doesn't help readability. However, in adwaita theme by default where the bar is bigger, then the icons are still the same small size there, so i'm thinking there isn't bigger versions of these used icons included in gtk as else they would be bigger too in adwaita's bigger bar. So another icon theme would be needed presumably, or so i'm guessing atleast.

Edit2: BTW, just found out that gnome-icon-theme is actually adwaita-icon-theme, just got renamed 5 years ago into adwaita-icon-theme, which is default in gtk3, so installing new gtk icon theme should work I believe, if wanted. I could also find out which specific files are used for main toolbar and you could try replace them under there folder, but probably easier simply use alternative gtk icon theme instead.

[PhiliP]

@ Mhertz

Thank you for you reponse.

I use the last check option installer theme option , because it is simply perfectly integrated with W10 (at least the window itself)

I've tried yesterday before posting a new GTK3 theme and it wasn't working. I trie again to be sure and i get back otherwis, i woild like to do your second proposition.

[mhertz]

@all

Sorry, if you have downloaded and installed in the last hour, then there where an issue with those installers, and so I apologize for the inconvenience, and just reverted the installers to previous version uploaded.

The thing wrong with the previous installers, where some of the toolbar icons where not the normal used ones and little strange looking imho, 2 of them, and also if using adwaita theme, then the close button at top right, had a strange symbol for icon not used before, that was the issue, and nothing wrong functionaity wise. Still, untill I can figure out what wen't wrong, then I reverted them in mean time to previous version.

I fixed the hard to read part of the default win32 theme in these installers in the removed installers, but instead of adding the fix in a new theme in new folder, then the more proper way to do it, is to make a patch and patch the source gtk3 files and rebuild gtk3 again with built-in change, so I decided to do that, and while doing so, then patched gvsbuild to use latest gtk3, even though nothing important for us, but regardless. There where also updated adwaita icon theme in gvsbuild, and before then gvsbuild stated some missing files duing building adwaita icon theme, but no real error which would stop the build-process, and this didn't happen this time, but as said now there are strange icons used someplaces. In the changelog of the new icon theme there where no such change reported, and the only change during building was there where now no missing files, but why that should result in wrong icons I have no idea, and have to research the reason first.

I apologize again for any inconvenience, and should have checked it better, but initially just thought the new icons in win32 theme where a normal thing since possible part of said missing files before, but I don't think so now, when seeing the strange close button in adwaita, which can't be normal imho, and can't see it online in pics either.

The icon for close button in adwaita, should be taken from UI folder, as windows-close-symbolic-symbolic.png, but I see it's other icon than previously, and can not check source on github as empty there and built during install from makefile, and i'm perplexed about reasoning for this, but will investigate it more and report back when found something out, but it will take a while, as each gtk3 rebuild run takes some time already and done in VM etc. This issue isn't reported online neither.

I have posted shoots of the default win32 theme, with fixed hard to read part(white text on light-grey is now black text on light-grey - I could also have kept white text and changed background to darker or whatever, or instead make it function as adwaita theme where no light-grey fields at all and focused fields from getgo are blue with white text, but decided on this in end, hope it's okay for ya'll, and note I kept the way the theme makes focused elements with mouse blue with white text afterwards, and this is just the default startup and called unfocused selection, something not in e.g. adwaita theme, where everything is focused selection from onset, and win32 theme looks the same when selecting something with mouse(white text on blue background), but again, not available yet as I reverted these installers) which shows the icon issues of the previous installers I now reverted. I included as third shot, the way it looks currently in reverted installers, with proper icons, but still issue of hard to read text. Also in third shot can be seen the issue of error of trackers sometimes of libtorrent 1.2.x, which is a deluge issue that can be ignored completely and I have reported it on deluge bugtracker, and libtorrent 1.2.3 available still if you care about this cosmetic issue untill fixed.

@PhiliP, i'm sorry, I took my plate a little to full I must confess, and I idon't have time to locate the files needed and replace them, as to big task honestly, if that is what you ment with the second proposition(I blabbed on so much, that got confused which part you meant, a bad trait of mine to have trouble just keeping things explained short and to the point )

When I have fixed this, hopefully, i'll upload a folder to you where you can change font size and mess around yourself if wanted with more things, as to much for me honestly, atleast currently, and other then that, then if you need help installing an icon theme then i'll help you out if I can, but will have to get back to you on that, but if you have problems with one specifically, then tell me the name/link and i'll see if I can do it and post directions.

[Paralel]

Wow, mhertz, I'm amazed at the progress you have made. You've managed to conquer all the major issues with the various pieces of Deluge, including GVSBuild. I don't see why they don't just take your installer and make it the default for Windows. I can't honestly think of any major outstanding issues at this point.

[mhertz]

Thank you for putting a big smile on my face with such a nice message, I really appreciate the kind words Paralel, thanks alot mate!

[mhertz]

Libtorrent updated to v1.2.6 today I saw in git commit log, though not yet announced officially on website.

Libtorrent 1.2.x from these installers are already almost up-to-date and only missing small commit from yesterday improving logic of peer-timeouts, but I rebuilt libtorrent/installers now with it and uploaded. I also rebuilt gvsbuild with reverted working adwaita-icon-theme package and my fix to default win32 theme for better readability of unfocused selection fields and used newest gtk3 version, even though compared to previous next-last version nothing relevant for deluge, but might as well use newest sources anyways.

I will have to submit new ticket on gvsbuild's github and ask for help for the adwaita-icon-theme issue, as seriously don't know what that's about i.e. I have same version of that package installed on linux and e.g. the file: '/usr/share/icons/adwaita/16x16\ui\window-close-symbolic-symbolic.png' is completely different to the file on the windows version from gvsbuild. It's correctly a png with an X symbol on linux, whereas some strange symbol on windows, which can be seen in my previous posted screenshoots. The png icon files adjacent to that, for minimize and maximize, are correct and same also on windows. Anyway, nothing important for us anyways in newest icon-theme version regarding deluge neither, so doesn't matter reverting, but would just like to figure out what issue is, also to help others out on gvsbuild's github, reading said ticket and/or if fix can be applied upstream too, e.g. if nothing else then revert version like me.

I'm messing little around with trying change title-bar of default win32 theme to look native for win10 instead of win7, but it's not using icon files that can be replaced and instead reference win32 api's and system dll's with old icons. I managed to ditch those icons in one test, but the result looked like crap, so might as well use win7-look than something more ugly, but i'll keep digging at it, when time/motivation permits. Note, again, all this is irrelevant if using GTK_CSD=0 option in installer of course, as then uses native win10 theming for drawing the title-bar, and personally I don't myself notice any performance degredation with said option, but haven't benchmarked it though, and only use shortly in quick testings with one or two torrents.