sketchy patch for #2098

Suggestions and discussion of future versions
Post Reply
grebb
New User
New User
Posts: 4
Joined: Sun Oct 24, 2010 6:01 pm

sketchy patch for #2098

Post by grebb »

I've started implementing http://dev.deluge-torrent.org/ticket/2098. The main feature for me was actually to open/run the actual torrent root, whether it be a file or folder. But the beginnings of the rest is there as well.
Unfortunately I can't compile on either windows or os x so only the linux/ubuntu part is finished/tested.
Please have a try. Here is my fork https://github.com/aronj/deluge.

Edit: Now all it needs is a keylistener on Return and a mouselistener on double-click for epic torrenting. :)
Cas
Top Bloke
Top Bloke
Posts: 3681
Joined: Mon Dec 07, 2009 6:04 am
Location: Scotland

Re: sketchy patch for #2098

Post by Cas »

The code for finding the largest file wouldn't go into that function. I don't know if it's a useful function but it much easier for the ui client to determine the largest file and then highlight it.

I have been testing different ideas for this ticket: https://github.com/cas--/Deluge/tree/Fe ... hlightFile

For nautilus the --select option is not available in versions below 3.8 iirc so adds extra headache however I have found that using dbus on linux would likely be the best option.

Whatever we implement for linux it has to work across most, if not all, distros.
grebb
New User
New User
Posts: 4
Joined: Sun Oct 24, 2010 6:01 pm

Re: sketchy patch for #2098

Post by grebb »

Your solution looks really good. I really hope to see it implemented because I wouldn't mind the defects you mention.
Post Reply