Page 1 of 1

Can not stop daemon from Web UI

Posted: Thu Mar 28, 2024 1:59 am
by aedfnis
when I click "Stop Daemon" from web ui, it show an error occurred, but no error found in web ui log or deluged log.

Image

Re: Can not stop daemon from Web UI

Posted: Mon May 13, 2024 5:09 am
by pirosa
I have submitted a pull request [WebUI]Fix Connection Manager stop daemon, return 5 elem from get_host_info() that seems to have daemon starting/stopping successfully from the WebUI for me. I don't know if the proposed changes might break the GTK version, however, as I have never tried it.

Re: Can not stop daemon from Web UI

Posted: Mon May 13, 2024 7:22 am
by mhertz
Thanks alot buddy, also for the other PR you submitted, much appreciated :) I'll check later today if it makes troubles to rest UIs and post back if does.

Edit: Not a dev myself btw, just an appreciative user, just to make sure above not misconstrued to mean something else.

Re: Can not stop daemon from Web UI

Posted: Mon May 13, 2024 1:43 pm
by mhertz
I couldn't see any interference with the other UIs and could manipulate hosts and shutdown daemons fine, good job! :)

deluge.ui.hostlist.get_host_status() is also only called by the webUI wrapper deluge/ui/web/json_api.py, for this, I believe.

Initially that deluge.ui.hostlist component was added with the get_host_status including passwords, but following commit changed it, plus the comments, so seems intended, though as said, nothing else uses it, I believe - could be instead changed in the webUI wrapper's _get_host() to isolate, but have no idea what's best or not, so please don't take this as anything else but smalltalk, as i'm not qualified to talk on that :)

Thanks again.