Re: Deluge not reporting hash-checks properly
Posted: Thu Feb 08, 2024 12:18 pm
Hello guys, and nice to see you bengalih interesting discussion you're having, and not gonna interrupt your back and fourths here, except to say thanks for reporting bengalih, and sorry I should have posted a big warning or something in the ltconfig thread, and looked into fixing if needed, and reporting upstream possibly, been little lazy about it, plus later forgot, when I also noticed this discrepancy some years ago during own testing with ltconfig. I will look into it later and post back if making something, or have some input atleast. Agreed would be nice if ltconfig got forked and maintained properly, though just don't feel like i'm good enough at that personally.
I'm waiting to post back in the ltconfig thread until having something atleast somewhat intelligent to say, so not ignorring you there, just adding both replies here. The libtorrent settings and dht and few more smaller stuff is saved and restored between runs and at x mins, like ambipro stated, for easy and fast restoral of such for clients by libtorrent API(so don't need code those settings manually back to session), and for deluge this isn't an issue, but for plugins like ltconfig, then it gets sorta misleading when deleting stuff from config-file's as bengalih found. Thinking about it, then little tricky because when option not in config, then ltconfig have no way of knowing if changed by itself in older times and later deleted, or if deluge or some other plugin did, but atleast it knows for a fact that it didn't itself have settings defined for ammending said option now and hence lists it as unconfigured by itself, as is correct, for current session and not back in time, but very much misleading agreed. I must confess I didn't read 100% close everything in this thread, and have to read back more close about suggested workarounds etc. Also I have to check how exactly ltconfig does it's saving and what default libtorrent preset explicitly is/is-gotten etc(I know what it sounds like obviously, but just making sure, as e.g. like high-performance-seed preset just is a hardcoded set of settings in ltconfig surpricingly to me, and not actually gotten from libtorrents own function for it i.e. using high_performance_seed() function). So, my humble opinion is this isn't deluge's problem, but a damn big problem regardless, from a usability standpoint. Yes you can delete session.state fine, and then you only just loose any options not already hardcoded by deluge or ltconfig. Hmm, have to check if changing an option in deluge itself, and then later deleting said changed option from core.conf and then restarting deluge, if it also shows option as unset in GUI, despite is set, previously, and so restored from session.state, and so if that is the case, which sounds like it actually, then indeed also a deluge issue - well you could say we are not supposed to do that, but still. Requires some thought(maybe some I said above is wrong possibly, or misunderstood, very possible), like you guys are doing nicely
Thanks guys
I'm waiting to post back in the ltconfig thread until having something atleast somewhat intelligent to say, so not ignorring you there, just adding both replies here. The libtorrent settings and dht and few more smaller stuff is saved and restored between runs and at x mins, like ambipro stated, for easy and fast restoral of such for clients by libtorrent API(so don't need code those settings manually back to session), and for deluge this isn't an issue, but for plugins like ltconfig, then it gets sorta misleading when deleting stuff from config-file's as bengalih found. Thinking about it, then little tricky because when option not in config, then ltconfig have no way of knowing if changed by itself in older times and later deleted, or if deluge or some other plugin did, but atleast it knows for a fact that it didn't itself have settings defined for ammending said option now and hence lists it as unconfigured by itself, as is correct, for current session and not back in time, but very much misleading agreed. I must confess I didn't read 100% close everything in this thread, and have to read back more close about suggested workarounds etc. Also I have to check how exactly ltconfig does it's saving and what default libtorrent preset explicitly is/is-gotten etc(I know what it sounds like obviously, but just making sure, as e.g. like high-performance-seed preset just is a hardcoded set of settings in ltconfig surpricingly to me, and not actually gotten from libtorrents own function for it i.e. using high_performance_seed() function). So, my humble opinion is this isn't deluge's problem, but a damn big problem regardless, from a usability standpoint. Yes you can delete session.state fine, and then you only just loose any options not already hardcoded by deluge or ltconfig. Hmm, have to check if changing an option in deluge itself, and then later deleting said changed option from core.conf and then restarting deluge, if it also shows option as unset in GUI, despite is set, previously, and so restored from session.state, and so if that is the case, which sounds like it actually, then indeed also a deluge issue - well you could say we are not supposed to do that, but still. Requires some thought(maybe some I said above is wrong possibly, or misunderstood, very possible), like you guys are doing nicely
Thanks guys