Fixed a few hours ago by gazpachoking here:
https://github.com/deluge-torrent/delug ... 34da85c259
(Edit: Just woke up, PR, not actually merged, sorry, need more coffee apparently.)
(Edit: Merged now:
https://github.com/deluge-torrent/delug ... 6e182db7c5)
Awesome to see all this dev-action, thanks alot all
Not important, but can save little time when building gtk, and have it(gtk)20mb smaller, by using 'gtk3 adwaita-icon-theme hicolor-icon-theme pycairo pygobject'(no '--skip' needed then, as was only referencing gtk3-full added elements), this just omits 'enchant' and 'wing' btw, from what you use(doadin/upstream). Also, don't need an extra recourse step for finding libtorrent.pyd if adding 'stage_module'' arg to b2(placed in current dir). Last, just to correct something I previously said, was that my notion of only needing two components defined(vc.tools.x86.x64/windows10sdk) when installing msvc, was because I use msvc-buildtools, whereas didn't even notice doadin using comunity-edition, which makes a diff e.g msbuild specifically need defined upon latter etc(many of doadin's defined deps are from msbuild btw, didnt cross-check though) . Think still is that typo previously mentioned too(Get-Childitem if remember correct), but don't know much about it honestly as never ran script fully, and not in long time neither. As said, not important(hopefully not long, and with nice CI setups and all), atleast mostly, and just little commenting
Thanks for all your work doadin again.
Edit: Also, for libtorrent I'd use 'optimize=speed'(instead of 'space') and "lto=on"(thanks petersasi). Additionally, as Arvid mentions hashing is one of the biggest culprits in high-speed torrenting, then i'd not just copy over the python built openssl for libtorrent to use, but instead build myself, because otherwise has asm-off defined, which I've seen mentioned yielding 10-15% degradation in performance roughly(openssl performance), and then can likewise enable LTO(WPO), just need do through cflags/ldflags here. BTW, I previously stated the two dll's included with python was from pyopenssl, which was wrong sorry, and was from 'ssl' module, which I thought was named pyopenssl, sorry. Last, checkboxes in nsis-script for dark-mode(fileopen/filewrite/fileclose settings.ini) and for disabling max-path(reg+exe-manifest - maybe pyinstaller already does manifest, never checked), like qbittorrent etc. would be cool imho - likewise maybe even one for libtorrent v2.x instead of v1.2.x possibly(or as radioboxes). Just a thought, though of-course for later, and not now, I obviously understand.
