Page 1 of 1
deluge-web 0a12d1507 (20150901) starts ?dev=true by default
Posted: Thu Sep 03, 2015 8:00 am
by alllexx
Whenever I access deluge web, it starts in ?dev=true mode by default. This leads to errors, since I don't package ext-base-debug.js and ext-all-debug.js (they're not included when you run `python setup.py sdist`). If I manually add '?dev=false', it works properly.
This happens after upgrading to this commit:
http://git.deluge-torrent.org/deluge/co ... 6a2d12a320
Previous version I packaged worked properly:
http://git.deluge-torrent.org/deluge/co ... 284ab54beb
So there's something wrong between these two commits. Please fix
Re: deluge-web 0a12d1507 (20150901) starts ?dev=true by defa
Posted: Thu Sep 03, 2015 8:26 am
by Cas
I don't think that is the reason, I suspect the actual reason is because you are running a version that includes 'dev' in the number and webui will automatically be set to dev mode. I think sdist should actually export those two debug files, I'll have a look.
Re: deluge-web 0a12d1507 (20150901) starts ?dev=true by defa
Posted: Thu Sep 03, 2015 8:30 am
by alllexx
That doesn't explain why it worked with previous version (520fc233719a0557b327a156df0637284ab54beb): I packaged it the same way, it too had 'dev' in version string, was missing those two debug files, yet started with ?dev=false by default and worked fine
Re: deluge-web 0a12d1507 (20150901) starts ?dev=true by defa
Posted: Thu Sep 03, 2015 8:38 am
by alllexx
The previous version (
http://optware-ng.zyxmon.org/buildroot- ... -1_arm.ipk) has '2.0.0.dev428' as version string, yet it doesn't start with ?dev=true by default.
Thanks
Re: deluge-web 0a12d1507 (20150901) starts ?dev=true by defa
Posted: Thu Sep 03, 2015 5:29 pm
by Cas
Between those commit ranges there was only one change to webui
http://git.deluge-torrent.org/deluge/lo ... ?h=develop and it certainly would not affect js loading.
Re: deluge-web 0a12d1507 (20150901) starts ?dev=true by defa
Posted: Thu Sep 03, 2015 6:43 pm
by alllexx
It's strange, but I re-checked this on three different architectures (i686, arm and mipsel), and it's all the same, the way I described it. As a workaround, for now I'll symlink the missing ext-base-debug.js and ext-all-debug.js to ext-base.js and ext-all.js, respetively, in the packages.
Re: deluge-web 0a12d1507 (20150901) starts ?dev=true by defa
Posted: Sat Sep 05, 2015 5:50 am
by alllexx
OK, I updated to HEAD, changed version string to '2.0.0.20150902', and now it works in ?dev=false by default. I wonder why it behaved differently before? I also packaged those missing debug .js for development mode to work if triggered manually. A bug in sdist command to skip them?
Re: deluge-web 0a12d1507 (20150901) starts ?dev=true by defa
Posted: Sun Sep 06, 2015 5:31 am
by alllexx
Thanks to this commit
http://git.deluge-torrent.org/deluge/co ... 6d74c3e10a
`python setup.py install` can now be used to generate more slim packages. I just need to edit 'RELEASE-VERSION' to not include 'dev' (this is outside git tree, of course), and all debug files will be skipped. And WEB UI doesn't start in dev mode by default if there's no 'dev' in version string too.
Thanks a lot for this change!
Alex