Encryption UI suggestions
Posted: Tue May 26, 2009 6:38 am
Two suggestions for the encryption settings UI changes -
1. Rename the text
A better name for the "Encrypt entire stream" option would be "Prefer fullstream encryption".
This option only makes sense if the peer libtorrent is talking to supports/offers both handshake and fullstream encryptions - which is the only case in which this option influences libtorrent's behaviour - it does not guarantee encrypting the entire stream, it just chooses it if possible. Forcing encryption is the job of the encryption level setting.
2. Grey out for "Handshake" and "Full stream" levels
This option is meaningless when "Handshake" or "Full stream" is selected as the encryption level - so it makes sense to grey out this checkbox for anything other than "Either" as the encryption level setting.
1. Rename the text
A better name for the "Encrypt entire stream" option would be "Prefer fullstream encryption".
This option only makes sense if the peer libtorrent is talking to supports/offers both handshake and fullstream encryptions - which is the only case in which this option influences libtorrent's behaviour - it does not guarantee encrypting the entire stream, it just chooses it if possible. Forcing encryption is the job of the encryption level setting.
2. Grey out for "Handshake" and "Full stream" levels
This option is meaningless when "Handshake" or "Full stream" is selected as the encryption level - so it makes sense to grey out this checkbox for anything other than "Either" as the encryption level setting.