Page 1 of 1

a couple of cosmetical bugs in 1.1.0

Posted: Sun Jan 18, 2009 12:05 pm
by lvm
1. apply button on options tab looks a bit weird (I am using kubuntu hardy 64)
Image

2. blocklist timestamp in preferences-blocklist-info apparently shows when blocklist was last loaded - e.g. if I just started deluge it shows current time minus several seconds. This information is pretty much useless, I'd like it to show the actual blocklist timestamp - that www.deluge-torrent.org/blocklist/nipfilter.dat.gz is dated December 30, 2008.

Re: a couple of cosmetical bugs in 1.1.0

Posted: Sun Jan 18, 2009 1:00 pm
by johnnyg
lvm wrote:2. blocklist timestamp in preferences-blocklist-info apparently shows when blocklist was last loaded - e.g. if I just started deluge it shows current time minus several seconds. This information is pretty much useless, I'd like it to show the actual blocklist timestamp - that http://www.deluge-torrent.org/blocklist ... ter.dat.gz is dated December 30, 2008.
the time displayed seems to be the last modified time,

Code: Select all

stat ~/.config/deluge/blocklist.cache
the actual code in python which grabs the date is

Code: Select all

list_stats = os.stat(deluge.configmanager.get_config_dir("blocklist.cache"))
self.config["file_date"] = datetime.datetime.fromtimestamp(list_stats.st_mtime).ctime()
what's weird is that

Code: Select all

file ~/.config/deluge/blocklist.cache
gives a different last modified time (which seems to be older).
I'm not sure where it's reading that from or how you would do it in python.

Re: a couple of cosmetical bugs in 1.1.0

Posted: Sun Jan 18, 2009 2:27 pm
by lvm
johnnyg wrote:
lvm wrote:2. blocklist timestamp in preferences-blocklist-info apparently shows when blocklist was last loaded - e.g. if I just started deluge it shows current time minus several seconds. This information is pretty much useless, I'd like it to show the actual blocklist timestamp - that http://www.deluge-torrent.org/blocklist ... ter.dat.gz is dated December 30, 2008.
the time displayed seems to be the last modified time,

Code: Select all

stat ~/.config/deluge/blocklist.cache
In my case ~/.config/deluge/blocklist.cache (which I believe is not an actual blocklist file but a copy [re]created by Deluge each time it loads blocklist) has today's date and this date is shown in Info, while blocklist itself is dated December 30th. Note that since times when deluge didn't handle blocklist errors very well I wget blocklist from cron and Deluge sees it as a local file (URL in preferences-blocklist is a reference to a local file). Sorry, I should've mentioned it before.

Re: a couple of cosmetical bugs in 1.1.0

Posted: Mon Jan 19, 2009 8:19 am
by johnnyg
lvm wrote:
johnnyg wrote:
lvm wrote:2. blocklist timestamp in preferences-blocklist-info apparently shows when blocklist was last loaded - e.g. if I just started deluge it shows current time minus several seconds. This information is pretty much useless, I'd like it to show the actual blocklist timestamp - that http://www.deluge-torrent.org/blocklist ... ter.dat.gz is dated December 30, 2008.
the time displayed seems to be the last modified time,

Code: Select all

stat ~/.config/deluge/blocklist.cache
In my case ~/.config/deluge/blocklist.cache (which I believe is not an actual blocklist file but a copy [re]created by Deluge each time it loads blocklist) has today's date and this date is shown in Info, while blocklist itself is dated December 30th. Note that since times when deluge didn't handle blocklist errors very well I wget blocklist from cron and Deluge sees it as a local file (URL in preferences-blocklist is a reference to a local file). Sorry, I should've mentioned it before.
yes deluge downloads the latest blocklist to blocklist.download and only on a successful import does it move it to blocklist.cache.
I should mention that seeing deluge now hosts the blocklist you don't really need a local copy anymore.

EDIT: this has been added in SVN.