0.5.8RC2 released

[razhar]

Main things are that this fixes the update notification from freezing or even crashing Deluge on some boxes (really sorry about this), and it allows you to pop sites out of the internal browser and into your system's default browser. Also you can select to never even see the browser icon. Full changelog here:
*Change add torrent to ctrl+n
*Change notification plugin to not show the file list, but only the torrent name
* Allow removal of browser icon from toolbar
* Add buttons to browser to launch the main and footer frames into an external browser
* Fix removing torrents from deluge template of webui - vonck7
* Set the advanced webui template as default
* Cut down significantly on the memory usage of the blocklist plugin
* Fix some UPnP bugs
* Fix "New version" alert from freezing sometimes
* Prioritizes local peers over non-local ones when finding connect
* Wish everyone a happy holiday

but it consumed 99% of cpu within 5minutes.....it made my pc to crawl....the download speed is good,if compared to utorrent..BUT 99% of cpu is disaster...

[andar]

I have one more suggest, how about add a check if bookmarks.save exists then trying to load it? It is useful for first time user and for any user that never touch the bookmark feature. It will quiet an annoy of this:

Code: Select all

Unable to load bookmarks file: %s [Errno 2] No such file or directory: '/usr/home/mezz/.config/deluge/mozilla/bookmarks.save'

I have created a patch to quiet it by add "os.path.exists".

http://people.freebsd.org/~mezz/diff/pa ... ookmark.py

What do you think? Unless, you prefer to create bookmarks.save when user click on 'Browser' button.

There is no point for this, that is what the catch it for.

[Ux64]

Unmanaged crash when adding new torrent.

Code: Select all

terminate called after throwing an instance of 'libtorrent::invalid_encoding'
  what():  invalid bencoding
Aborted

how was it added?

From piratebay directly using Firefox and Open in Deluge option.

I also have another strange phenomenon, I'm not sure if it's about this version or if it's about the torrents I'm downloading. For some reason Deluge UI freezes (stops updating) but if I pause all torrents and resume those after that update happens once / seconds as it happens normally. I haven't had this problem ever before this version(?), so it might be related to it. It usually happens after long long checking of files. But files should be downloading correctly after that.

I can't (yet) pinpoint the problem with existing experience. So I hope if someone has similar problems and could tell more exact details.

Oh yeah, I checked CLI output... Nothing... Just pickling state and after that it works again.

but it consumed 99% of cpu within 5minutes.....it made my pc to crawl....the download speed is good,if compared to utorrent..BUT 99% of cpu is disaster...

Are you sure that it wasn't checking files? What kind of CPU you got?

P.S. Anyone, is there that Move torrent patch or update for this latest version. - Thanks!

[mezz]

I have one more suggest, how about add a check if bookmarks.save exists then trying to load it? It is useful for first time user and for any user that never touch the bookmark feature. It will quiet an annoy of this:

Code: Select all

Unable to load bookmarks file: %s [Errno 2] No such file or directory: '/usr/home/mezz/.config/deluge/mozilla/bookmarks.save'

I have created a patch to quiet it by add "os.path.exists".

http://people.freebsd.org/~mezz/diff/pa ... ookmark.py

What do you think? Unless, you prefer to create bookmarks.save when user click on 'Browser' button.

There is no point for this, that is what the catch it for.

It doesn't make any sense to try to load something that don't exist. You have to check if file exists before try to load (open) file. As I have pointed, unless you prefer to create bookmarks.save when click on 'Browser' button then you can remove that check because bookmarks.save will be always exists.

[razhar]

Unmanaged crash when adding new torrent.

Code: Select all

terminate called after throwing an instance of 'libtorrent::invalid_encoding'
  what():  invalid bencoding
Aborted

how was it added?

From piratebay directly using Firefox and Open in Deluge option.

I also have another strange phenomenon, I'm not sure if it's about this version or if it's about the torrents I'm downloading. For some reason Deluge UI freezes (stops updating) but if I pause all torrents and resume those after that update happens once / seconds as it happens normally. I haven't had this problem ever before this version(?), so it might be related to it. It usually happens after long long checking of files. But files should be downloading correctly after that.

I can't (yet) pinpoint the problem with existing experience. So I hope if someone has similar problems and could tell more exact details.

Oh yeah, I checked CLI output... Nothing... Just pickling state and after that it works again.

but it consumed 99% of cpu within 5minutes.....it made my pc to crawl....the download speed is good,if compared to utorrent..BUT 99% of cpu is disaster...

Are you sure that it wasn't checking files? What kind of CPU you got?

it says 'downloading'...with 2 active torrents...p4..1.8,512MB
P.S. Anyone, is there that Move torrent patch or update for this latest version. - Thanks!

[scrapmetal]

small bug in the move torrent plugin i think

if i set move torrent to move the downloaded file(s) when done AND set stop seeding to for example 1.5 AND enable automaticly clear torrents when reach max share ratio and if all these 3 occur at the same time (i.e. if ive already have a seed ratio of more than 1.5 when the download is finished) then the torrent doesent get moved

[Ux64]

small bug in the move torrent plugin i think

if i set move torrent to move the downloaded file(s) when done AND set stop seeding to for example 1.5 AND enable automaticly clear torrents when reach max share ratio and if all these 3 occur at the same time (i.e. if ive already have a seed ratio of more than 1.5 when the download is finished) then the torrent doesent get moved

Yep, I have discusses this problem earlier here: http://forum.deluge-torrent.org/viewtop ... hilit=move

Someone even made patch for it. Which you can find from that thread. Unfortunately it might not be compatible with current version. I were kind of hoping that the patch would have been included to official version.

I personally find this move torrent "feature" currently the most annoying thing with Deluge. Because I need to compare list of files to list of active tasks in Deluge to find which files I might to move out from download directory. But I can live with it.

There is quite a list of things for Deluge that are kind of usability issues and should be fixed. But it'll take some time.

Another is skipping files when using compact allocation. But I mostly download complete torrents so that doesn't bother me so much.

P.S. Is there wiki or some pretty list with priorities what shall be fixed and done in future? Future change log, things to be done. Including planned and confirmed changes and open wishes from users.

[markybob]

small bug in the move torrent plugin i think

if i set move torrent to move the downloaded file(s) when done AND set stop seeding to for example 1.5 AND enable automaticly clear torrents when reach max share ratio and if all these 3 occur at the same time (i.e. if ive already have a seed ratio of more than 1.5 when the download is finished) then the torrent doesent get moved

this is fixed in svn and will be in 0.5.8 final. thanks.

Another is skipping files when using compact allocation. But I mostly download complete torrents so that doesn't bother me so much.

no bittorrent client allows for file selection with compact allocation. not utorrent, not azureus, none. it's just not possible. it will always require full allocation

[Ux64]

Another is skipping files when using compact allocation. But I mostly download complete torrents so that doesn't bother me so much.

no bittorrent client allows for file selection with compact allocation. not utorrent, not azureus, none. it's just not possible. it will always require full allocation

Ok. I just changed my Deluge allaction setting to full. So I don't bother you with this issue anymore.

But, to be truthful. uTorrent allows you to skip files even when using compact allocation. I just checked that fact and also tired it out to confirm that fact.

And even if uTorrent wouldn't. I don't see any technical reason how full or compact allocation would interfere with skipping files. If you have a pointer to document explaining this, I will be very happy to read it. I couldn't find any, even I did read libtorrent documentation.

It seems that other clients using libTorrent have same problem. (rTorrent discussion)
http://osdir.com/ml/network.bit-torrent ... 00001.html

I know it isn't Deluges problem, it's libtorrent problem. As you mention in that discussion.

And also it seems to be an old topic:
http://dev.deluge-torrent.org/ticket/506

Thanks markybob, I'm sure that Deluge will deal with this issue when libtorrent does.

this is fixed in svn and will be in 0.5.8 final. thanks.

And I'm very happy to hear that move torrent issue has been finally fixed in next release.

[markybob]

Another is skipping files when using compact allocation. But I mostly download complete torrents so that doesn't bother me so much.

no bittorrent client allows for file selection with compact allocation. not utorrent, not azureus, none. it's just not possible. it will always require full allocation

Ok. I just changed my Deluge allaction setting to full. So I don't bother you with this issue anymore.

But, to be truthful. uTorrent allows you to skip files even when using compact allocation. I just checked that fact and also tired it out to confirm that fact.

And even if uTorrent wouldn't. I don't see any technical reason how full or compact allocation would interfere with skipping files. If you have a pointer to document explaining this, I will be very happy to read it. I couldn't find any, even I did read libtorrent documentation.

It seems that other clients using libTorrent have same problem. (rTorrent discussion)
http://osdir.com/ml/network.bit-torrent ... 00001.html

I know it isn't Deluges problem, it's libtorrent problem. As you mention in that discussion.

And also it seems to be an old topic:
http://dev.deluge-torrent.org/ticket/506

Thanks markybob, I'm sure that Deluge will deal with this issue when libtorrent does.

this is fixed in svn and will be in 0.5.8 final. thanks.

And I'm very happy to hear that move torrent issue has been finally fixed in next release.

utorrent uses something called part-file, which is really quite different. and we dont currently support part-file (since libtorrent doesnt)