Re: Deluge 2.0 Windows 7z sfx installer available.
Posted: Fri Nov 29, 2019 12:42 am
That registry-key seems correct, so that's strange indeed...
About the non-functioning association-button in GTKUI, then I checked the deluge code for this, and I can see it calls a function for retrieving folder-path deluge is installed in, and then appends "deluge.exe" "%1" to that, and adds to registry, same key as you.
This works normally, but in my installer, which is based on Cas's install-instructions, have deluge.exe in a subfolder named 'Scripts' and so the association isn't valid because wrong path added to registry when hitting that button in GTKUI.
So, I fixed the deluge code to set correct path to deluge.exe in registry now, when hitting the button, and I checked it in firefox by selecting an arch-linux ISO magnet-link from this page, which worked fine and started deluge and loaded the magnet in: https://www.archlinux.org/download/
Note, there's a bug in deluge2 I have submitted a ticket about previously, which makes magnet links not being able to prefetch metadata(show files in torrent) when thinclient-mode is used, for some strange reason, but is reproducible on both linux and windows i've checked. However, this doesn't really matter for simple downloading, as you can still select to add the torrent(well, magnet) and it will download fine, but before selecting 'add', then it will continue loading and showing that wheel turning continuously, as it cannot download metadata, but as said, just select 'add' instead of waiting forever, when getting that dialog.
I was also thinking about adding those regsitry associations from my installer automatically, but I have to think about how doing it best, as don't like doing it unconditionally, as if someone wouldn't wanting it for some reason, and i'm not sure my "installer system" I use(7z sfx installer module modified with extra features relevant for installers) supports adding in checkboxes, other than that path-choosing dialog for selecting install-location, which I alreasy use. It does though support install-switches, but that becomes to cumbersome for the end-user I think, though easy for me to add. I'll look into that later.
I have updated all 4 installers with fixed magnet association when hitting that GTKUI button.
About the non-functioning association-button in GTKUI, then I checked the deluge code for this, and I can see it calls a function for retrieving folder-path deluge is installed in, and then appends "deluge.exe" "%1" to that, and adds to registry, same key as you.
This works normally, but in my installer, which is based on Cas's install-instructions, have deluge.exe in a subfolder named 'Scripts' and so the association isn't valid because wrong path added to registry when hitting that button in GTKUI.
So, I fixed the deluge code to set correct path to deluge.exe in registry now, when hitting the button, and I checked it in firefox by selecting an arch-linux ISO magnet-link from this page, which worked fine and started deluge and loaded the magnet in: https://www.archlinux.org/download/
Note, there's a bug in deluge2 I have submitted a ticket about previously, which makes magnet links not being able to prefetch metadata(show files in torrent) when thinclient-mode is used, for some strange reason, but is reproducible on both linux and windows i've checked. However, this doesn't really matter for simple downloading, as you can still select to add the torrent(well, magnet) and it will download fine, but before selecting 'add', then it will continue loading and showing that wheel turning continuously, as it cannot download metadata, but as said, just select 'add' instead of waiting forever, when getting that dialog.
I was also thinking about adding those regsitry associations from my installer automatically, but I have to think about how doing it best, as don't like doing it unconditionally, as if someone wouldn't wanting it for some reason, and i'm not sure my "installer system" I use(7z sfx installer module modified with extra features relevant for installers) supports adding in checkboxes, other than that path-choosing dialog for selecting install-location, which I alreasy use. It does though support install-switches, but that becomes to cumbersome for the end-user I think, though easy for me to add. I'll look into that later.
I have updated all 4 installers with fixed magnet association when hitting that GTKUI button.