Page 2 of 4
Re: 0.5.8RC2 released
Posted: Wed Dec 26, 2007 7:30 pm
by mezz
mezz wrote:Ah, I see, I have found LD_LIBRARY_PATH and MOZILLA_FIVE_HOME in scripts/deluge. Let me hack around and file a new ticket with a patch when I get it works. Thanks for hint!
I have got it works with hack, but I am not going to file a new ticket yet. Since FreeBSD's python-gnome2-extras supports anyone to compile with different gecko options (SeaMonkey, Firefox and etc). The default is Firefox. Here's what I have made some change in local.
Code: Select all
import os, platform
[...]
print "checking for ubuntu..."
if not deluge.common.windows_check():
if platform.system() == "Linux": # Add this, FreeBSD and other OSs than Linux do not have /etc/issue.
if os.WEXITSTATUS(os.system('grep -iq "Ubuntu" /etc/issue')) == 0:
print "found and fixing ubuntu"
if os.environ.get("MOZILLA_FIVE_HOME") != "/usr/lib/firefox":
os.environ["MOZILLA_FIVE_HOME"] = "/usr/lib/firefox"
os.environ["LD_LIBRARY_PATH"] = "/usr/lib/firefox"
os.system("/usr/bin/deluge")
raise SystemExit
if platform.system() == "FreeBSD":
if os.environ.get("MOZILLA_FIVE_HOME") != "/usr/local/lib/firefox":
os.environ["MOZILLA_FIVE_HOME"] = "/usr/local/lib/firefox"
os.environ["LD_LIBRARY_PATH"] = "/usr/local/lib/firefox"
os.system("/usr/local/bin/deluge")
raise SystemExit
I would suggest you to add check on Linux before grep on /etc/issue, but don't add check on FreeBSD part. I will keeping check on FreeBSD part patch in our ports tree as it will be supporting on users' choice of gecko (SeaMonkey, Firefox and etc).
Re: 0.5.8RC2 released
Posted: Wed Dec 26, 2007 7:32 pm
by markybob
mezz wrote:mezz wrote:Ah, I see, I have found LD_LIBRARY_PATH and MOZILLA_FIVE_HOME in scripts/deluge. Let me hack around and file a new ticket with a patch when I get it works. Thanks for hint!
I have got it works with hack, but I am not going to file a new ticket yet. Since FreeBSD's python-gnome2-extras supports anyone to compile with different gecko options (SeaMonkey, Firefox and etc). The default is Firefox. Here's what I have made some change in local.
Code: Select all
import os, platform
[...]
print "checking for ubuntu..."
if not deluge.common.windows_check():
if platform.system() == "Linux": # Add this, FreeBSD and other OSs than Linux do not have /etc/issue.
if os.WEXITSTATUS(os.system('grep -iq "Ubuntu" /etc/issue')) == 0:
print "found and fixing ubuntu"
if os.environ.get("MOZILLA_FIVE_HOME") != "/usr/lib/firefox":
os.environ["MOZILLA_FIVE_HOME"] = "/usr/lib/firefox"
os.environ["LD_LIBRARY_PATH"] = "/usr/lib/firefox"
os.system("/usr/bin/deluge")
raise SystemExit
if platform.system() == "FreeBSD":
if os.environ.get("MOZILLA_FIVE_HOME") != "/usr/local/lib/firefox":
os.environ["MOZILLA_FIVE_HOME"] = "/usr/local/lib/firefox"
os.environ["LD_LIBRARY_PATH"] = "/usr/local/lib/firefox"
os.system("/usr/local/bin/deluge")
raise SystemExit
I would suggest you to add check on Linux before grep on /etc/issue, but don't add check on FreeBSD part. I will keeping check on FreeBSD part patch in our ports tree as it will be supporting on users' choice of gecko (SeaMonkey, Firefox and etc).
great, thanks. i'll fix this for final
Re: 0.5.8RC2 released
Posted: Wed Dec 26, 2007 8:15 pm
by nargh
markybob wrote:Allow removal of browser icon from toolbar
Thanks... it still would be good for torrent-search & anon-browser to go back to plugins.. especially if even file-selection and network-health are plugins.
On the other hand, the detailed progress bar now is somehow broken - it's late to display chunks as downloaded.
Re: 0.5.8RC2 released
Posted: Wed Dec 26, 2007 8:55 pm
by mezz
I have one more suggest, how about add a check if bookmarks.save exists then trying to load it? It is useful for first time user and for any user that never touch the bookmark feature. It will quiet an annoy of this:
Code: Select all
Unable to load bookmarks file: %s [Errno 2] No such file or directory: '/usr/home/mezz/.config/deluge/mozilla/bookmarks.save'
I have created a patch to quiet it by add "os.path.exists".
http://people.freebsd.org/~mezz/diff/pa ... ookmark.py
What do you think? Unless, you prefer to create bookmarks.save when user click on 'Browser' button.
Re: 0.5.8RC2 released
Posted: Wed Dec 26, 2007 9:05 pm
by markybob
mezz wrote:I have one more suggest, how about add a check if bookmarks.save exists then trying to load it? It is useful for first time user and for any user that never touch the bookmark feature. It will quiet an annoy of this:
Code: Select all
Unable to load bookmarks file: %s [Errno 2] No such file or directory: '/usr/home/mezz/.config/deluge/mozilla/bookmarks.save'
I have created a patch to quiet it by add "os.path.exists".
http://people.freebsd.org/~mezz/diff/pa ... ookmark.py
What do you think? Unless, you prefer to create bookmarks.save when user click on 'Browser' button.
yeah, i guess we should. thanks.
Re: 0.5.8RC2 released
Posted: Wed Dec 26, 2007 10:03 pm
by mezz
Thanks!
Re: 0.5.8RC2 released
Posted: Thu Dec 27, 2007 7:21 pm
by Ux64
Unmanaged crash when adding new torrent.
Code: Select all
terminate called after throwing an instance of 'libtorrent::invalid_encoding'
what(): invalid bencoding
Aborted
Crash recovery is painfully slow because I have 150 gigabytes of stuff... Checking that takes a while. ;(
Is there any way to reduce need for complete check? Like managed shutdown in case of unexpected (non fatal) error?
Re: 0.5.8RC2 released
Posted: Thu Dec 27, 2007 7:29 pm
by markybob
Ux64 wrote:Unmanaged crash when adding new torrent.
Code: Select all
terminate called after throwing an instance of 'libtorrent::invalid_encoding'
what(): invalid bencoding
Aborted
Crash recovery is painfully slow because I have 150 gigabytes of stuff... Checking that takes a while. ;(
Is there any way to reduce need for complete check? Like managed shutdown in case of unexpected (non fatal) error?
how was it added?
Re: 0.5.8RC2 released
Posted: Thu Dec 27, 2007 10:36 pm
by teaBagger
Re: 0.5.8RC2 released
Posted: Fri Dec 28, 2007 2:22 am
by markybob
teaBagger wrote:
I had this same prob.
yeah, this is fixed in svn and will be in our next release