[Plugin] Auto Remove Plus v2.0.0

Suggest, post, or discuss plugins for Deluge
mhertz
Moderator
Moderator
Posts: 1288
Joined: Wed Jan 22, 2014 5:05 am
Location: Denmark

Re: [Plugin] Auto Remove Plus v2.0.0

Post by mhertz »

As is arch-based, and presumably up-to-date, then is using py3.9, meaning you need download py3.9 version of plugin and use, or if not available(or just being to lazy), then simply rename the 8 to 9, in the filename of the plugin, and restart deluge.
funkjunkman
New User
New User
Posts: 2
Joined: Mon Mar 01, 2021 2:11 pm

Re: [Plugin] Auto Remove Plus v2.0.0

Post by funkjunkman »

Confirmed latest release is running Python 3.9.2
Renaming plugin worked. Thanks!
LimitX
New User
New User
Posts: 2
Joined: Thu Mar 04, 2021 8:55 pm

Re: [Plugin] Auto Remove Plus v2.0.0

Post by LimitX »

Running in docker with linuxserver/deluge

Deluge version: 2.0.3-2-201906121747-ubuntu18.04.1
Python: 3.6.9

When I install the plugin via the web UI I see a new "file" in the plugins directory (/config/plugins) called "[object FileList]" but the plugin is not listed in the plugins list. Any ideas?
mhertz
Moderator
Moderator
Posts: 1288
Joined: Wed Jan 22, 2014 5:05 am
Location: Denmark

Re: [Plugin] Auto Remove Plus v2.0.0

Post by mhertz »

Yes, install plugin manually as this is an issue often reported(don't know if proper bugticket ever was submitted to the bugtracker about it, but still unfixed regardless) and happens with some plugins when using the webui install feature. Just place plugin into dockers /config mounted profile dir on host system and restart the docker image. Remember plugin filename should match python version of docker, so use a '*-py3.6.egg' plugin version or just instead rename to match.
LimitX
New User
New User
Posts: 2
Joined: Thu Mar 04, 2021 8:55 pm

Re: [Plugin] Auto Remove Plus v2.0.0

Post by LimitX »

mhertz wrote:Yes, install plugin manually as this is an issue often reported(don't know if proper bugticket ever was submitted to the bugtracker about it, but still unfixed regardless) and happens with some plugins when using the webui install feature. Just place plugin into dockers /config mounted profile dir on host system and restart the docker image. Remember plugin filename should match python version of docker, so use a '*-py3.6.egg' plugin version or just instead rename to match.
Thank you very much :-)
Ognisty321
New User
New User
Posts: 7
Joined: Fri Dec 25, 2020 4:29 pm

Re: [Plugin] Auto Remove Plus v2.0.0

Post by Ognisty321 »

I have a problem on mhertz deluge, (settings: https://i.imgur.com/egphEkk.png). It should delete torrents, wheen seed time exceed 1h, but it just doesn't do that, actually its doing nothing. Torrents are only deleted when I'm changing min seed time value to e.g 1.01 and apply that, then its deleting what it should. But I dont wan't do delete files manually by changing values, it should do that automatically :D Any ideas?
mhertz
Moderator
Moderator
Posts: 1288
Joined: Wed Jan 22, 2014 5:05 am
Location: Denmark

Re: [Plugin] Auto Remove Plus v2.0.0

Post by mhertz »

I don't have experience with this plugin, only checked it could be enabled before but had little free time so just checked, and when setting very low numbers just for quick testing, then works for me - could you try that?

I had same settings as your pic, except check time or whatever called was 0.01 and min seed-time 0.02, so every minute or little under(60min*0.01=0.6mins) and deleting litte under every 2 mins(well 1.2mins). You can backup original profile and test fresh and delete afterwards, to not mess up your torrents.

You could also check the logs as there's logging added upon every check etc, or atleast i've read springjool's other fork doing that so presume it's part of original deluge1 version, like this is based from too.
Ognisty321
New User
New User
Posts: 7
Joined: Fri Dec 25, 2020 4:29 pm

Re: [Plugin] Auto Remove Plus v2.0.0

Post by Ognisty321 »

I checked different settings and it's still not deleting anything. Maybe it's because of Thin Client? It shouldn't be
mhertz
Moderator
Moderator
Posts: 1288
Joined: Wed Jan 22, 2014 5:05 am
Location: Denmark

Re: [Plugin] Auto Remove Plus v2.0.0

Post by mhertz »

Strange, though this plugin has had several reports of not deleting for some(Linux users), and only did when opening the GUI again(when using thinclient) or going into preferences cannot remember, though was mostly for springjools fork I believe, but this fork here also newer. I cannot explain it, sorry, for me works same under Linux and my build, and works - I'm not testing this in thinclient mode btw, but shouldn't matter as you said. I personally always test with the latest magnet link for arch-linux, or Debian iso torrent, which I did the latter this time, and link can be pasted into url box like magnets, though should neither matter. Sorry no clue unfortunetly, and hopefully others have any ideas for you, though seemingly not a general issue however.

https://cdimage.debian.org/debian-cd/cu ... so.torrent

(Maybe also try springjools fork since this isn't working for you, though needs setup in webui first time, as no GTKUI prefs, or atleast not last I checked - or maybe it can read your config-file already I dunno how much is different with setting names between them.)

Edit: After PM corrospondance with Ognisty321 then I can reproduce and so only happens in thinclient-mode when GUI not open.

It runs upon every defined interval, I can see in log, but somehow miscalculates the rule defined so doesn't delete(unless i'm misunderstanding the logging), and when GTKUI opened then rule calculated correct and deletion happens correctly:

No-GUI logging:

Code: Select all

19:23:16.443 [DEBUG   ][deluge.plugin.autoremoveplus.core:245 ] AutoRemovePlus: do_remove
19:23:16.443 [DEBUG   ][deluge.plugin.autoremoveplus.core:268 ] WARNING! Label plugin not active
19:23:16.444 [DEBUG   ][deluge.plugin.autoremoveplus.core:269 ] No labels will be checked for exemptions!
19:23:16.444 [DEBUG   ][deluge.plugin.autoremoveplus.core:279 ] Number of torrents: 1
19:23:16.444 [DEBUG   ][deluge.plugin.autoremoveplus.core:342 ] Number of finished torrents: 1
19:23:16.444 [DEBUG   ][deluge.plugin.autoremoveplus.core:343 ] Number of ignored torrents: 0
19:23:16.445 [DEBUG   ][deluge.plugin.autoremoveplus.core:385 ] Needed space: -18.074493408203125
19:23:16.445 [DEBUG   ][deluge.plugin.autoremoveplus.core:386 ] Now processing name = debian-10.9.0-amd64-netinst.iso, type = <class 'str'>
19:23:16.445 [DEBUG   ][deluge.plugin.autoremoveplus.core:387 ] Size: 0.3291015625
19:23:16.445 [DEBUG   ][deluge.plugin.autoremoveplus.core:391 ] AutoRemovePlus: Remove torrent 9f292c93eb0dbdd7ff7a4aa551aaa1ea7cafe004, debian-10.9.0-amd64-netinst.iso
19:23:16.445 [DEBUG   ][deluge.plugin.autoremoveplus.core:395 ] 0.0
19:23:16.446 [DEBUG   ][deluge.plugin.autoremoveplus.core:398 ] 0.0
GUI logging:

Code: Select all

19:24:28.443 [DEBUG   ][deluge.plugin.autoremoveplus.core:245 ] AutoRemovePlus: do_remove
19:24:28.444 [DEBUG   ][deluge.plugin.autoremoveplus.core:268 ] WARNING! Label plugin not active
19:24:28.444 [DEBUG   ][deluge.plugin.autoremoveplus.core:269 ] No labels will be checked for exemptions!
19:24:28.444 [DEBUG   ][deluge.plugin.autoremoveplus.core:279 ] Number of torrents: 1
19:24:28.445 [DEBUG   ][deluge.plugin.autoremoveplus.core:342 ] Number of finished torrents: 1
19:24:28.445 [DEBUG   ][deluge.plugin.autoremoveplus.core:343 ] Number of ignored torrents: 0
19:24:28.446 [DEBUG   ][deluge.plugin.autoremoveplus.core:385 ] Needed space: -18.07427215576172
19:24:28.446 [DEBUG   ][deluge.plugin.autoremoveplus.core:386 ] Now processing name = debian-10.9.0-amd64-netinst.iso, type = <class 'str'>
19:24:28.446 [DEBUG   ][deluge.plugin.autoremoveplus.core:387 ] Size: 0.3291015625
19:24:28.447 [DEBUG   ][deluge.plugin.autoremoveplus.core:391 ] AutoRemovePlus: Remove torrent 9f292c93eb0dbdd7ff7a4aa551aaa1ea7cafe004, debian-10.9.0-amd64-netinst.iso
19:24:28.447 [DEBUG   ][deluge.plugin.autoremoveplus.core:395 ] 0.10944444444444444
19:24:28.447 [DEBUG   ][deluge.plugin.autoremoveplus.core:398 ] 0.0
19:24:28.448 [DEBUG   ][deluge.core.torrent              :1330] Deleting torrent file: /home/martin/.config/deluge/state/9f292c93eb0dbdd7ff7a4aa551aaa1ea7cafe004.torrent
19:24:28.449 [INFO    ][deluge.core.torrentmanager       :772 ] Torrent debian-10.9.0-amd64-netinst.iso removed by user: localclient
This isn't related to my build either, as e.g. above logs and test was on linux
Last edited by mhertz on Fri Apr 30, 2021 7:04 pm, edited 1 time in total.
mhertz
Moderator
Moderator
Posts: 1288
Joined: Wed Jan 22, 2014 5:05 am
Location: Denmark

Re: [Plugin] Auto Remove Plus v2.0.0

Post by mhertz »

I fixed this plugin to work also for dynamic conditions like seed-time etc in thinclient mode without any GUI open, as per reported by Ognisty321 here and several others before, here and/or on github.

AutoRemovePlus-2.0.0-py3.9.egg

Remember rename to match used python version, if needed.

After a bunch of testing, then finally found the issue being the TorrentManager get_status() deluge API call which defaults to return cached results from libtorrent, unless applying 'update=True' extra condition during the call, and which is done by the GTKUI when open, as else couldn't dynamically update e.g. seed-time values etc and so refreshes the cached values of libtorrent when the GUI opened, for the plugin to get.

I added this in code to requested dynamic fields like e.g. seed-time and ratio etc, but not static field requests like name or size etc, as no reason to waste resources and time for that.

I'll make a ticket later on the author's github project page to make note of the issue, so that official fix and release can be made.

Edit: No 'issues' section on tote94's github project page unfortunetly, so cannot make note of this there then - there's a PR section though, but I submitted a PR there regarding a small logging code fix, a year ago and still not merged or responded upon(springjools did respond there though however). I'm probably gonna submit a PR then anyways.
Last edited by mhertz on Sun May 02, 2021 10:31 am, edited 3 times in total.
Post Reply