pending pull request - do I need to do anything?

Suggestions and discussion of future versions
Post Reply
pjlbyrne
Leecher
Leecher
Posts: 59
Joined: Thu May 22, 2014 9:28 am

pending pull request - do I need to do anything?

Post by pjlbyrne »

So, I wanted to contribute to deluge, so I created a ticket, forked the repo on github, and created a pull request.
Now what? Do I just wait? I am in no hurry, I just want some closure here.

https://github.com/deluge-torrent/deluge/pull/295
https://dev.deluge-torrent.org/ticket/3406

Do I need to do anything else?

Thanks
Pat
mhertz
Moderator
Moderator
Posts: 2182
Joined: Wed Jan 22, 2014 5:05 am
Location: Denmark

Re: pending pull request - do I need to do anything?

Post by mhertz »

Thank you for your contribution firstly! :) Yes, you've done everything you've suppossed to do, and now it's just a waiting game to see if/when gets merged. As Cas replied to the ticket following yours, 16 hours ago, then probably not that long wait, and atleast you know it was most likely already looked at/noticed by lead-dev :)
pjlbyrne
Leecher
Leecher
Posts: 59
Joined: Thu May 22, 2014 9:28 am

Re: pending pull request - do I need to do anything?

Post by pjlbyrne »

okay brilliant thanks! I might do the add torrent dialog too, those text entries are really quite narrow for long torrent paths
pjlbyrne
Leecher
Leecher
Posts: 59
Joined: Thu May 22, 2014 9:28 am

Re: pending pull request - do I need to do anything?

Post by pjlbyrne »

still waiting!
Cas
Top Bloke
Top Bloke
Posts: 3679
Joined: Mon Dec 07, 2009 6:04 am
Location: Scotland

Re: pending pull request - do I need to do anything?

Post by Cas »

I get around to PRs when I can, with my current job I don't have much time/energy for Deluge code
Post Reply