Page 1 of 1

pending pull request - do I need to do anything?

Posted: Sun Jun 14, 2020 9:18 am
by pjlbyrne
So, I wanted to contribute to deluge, so I created a ticket, forked the repo on github, and created a pull request.
Now what? Do I just wait? I am in no hurry, I just want some closure here.

https://github.com/deluge-torrent/deluge/pull/295
https://dev.deluge-torrent.org/ticket/3406

Do I need to do anything else?

Thanks
Pat

Re: pending pull request - do I need to do anything?

Posted: Sun Jun 14, 2020 9:26 am
by mhertz
Thank you for your contribution firstly! :) Yes, you've done everything you've suppossed to do, and now it's just a waiting game to see if/when gets merged. As Cas replied to the ticket following yours, 16 hours ago, then probably not that long wait, and atleast you know it was most likely already looked at/noticed by lead-dev :)

Re: pending pull request - do I need to do anything?

Posted: Sun Jun 14, 2020 9:36 am
by pjlbyrne
okay brilliant thanks! I might do the add torrent dialog too, those text entries are really quite narrow for long torrent paths

Re: pending pull request - do I need to do anything?

Posted: Fri Jul 03, 2020 4:32 pm
by pjlbyrne
still waiting!

Re: pending pull request - do I need to do anything?

Posted: Fri Jul 03, 2020 6:37 pm
by Cas
I get around to PRs when I can, with my current job I don't have much time/energy for Deluge code