Adding duplicate torrent fails silently

[daddy]

Adding a duplicate torrent no longer emits a DuplicateTorrentError, which means it isn't caught in interactive_add_torrent_path (or in FlexRSS), so the merge trackers code is dead. Terminal outputs:

Code: Select all

Raising error: libtorrent reports this is a duplicate torrent
Error probably bad torrent

[markybob]

hrm :/ i wonder what happened. i'll look into it

[markybob]

hrm :/ i wonder what happened. i'll look into it

fixed

[danii]

in SVN the Autoload feature loads the torrent twice and if you accept both Deluge crashes as before with:

Code: Select all

Raising error: libtorrent reports this is a duplicate torrent
Error probably bad torrent
terminate called after throwing an instance of 'libtorrent::invalid_encoding'
  what():  invalid bencoding
Aborted

also if "Enable selecting files for torrents before loading" is on it shouldn't be on for Autoload, I think it's purpose is for unattended downloads so it doesn't make sense to exist a dialog
by the way torrent loading should detect if a torrent is private and set the private flag on for them by default (I kinda got banned from a tracker by missing to set it on once)

[markybob]

duplicate torrents dont give you an invalid encoding error. that means you have a bad torrent file

[danii]

torrent loads fine when I add it manually so it's valid, but Autoload loads the torrent 2 times, and if i don't click ok it just keeps on loading the file over and over again


did some more testing with different torrents and it only happens the 1st time a torrent is Autoloaded in current Deluge session

so to reproduce it:

Code: Select all

1. "Enable selecting files for torrents before loading" must be on
2. restart Deluge
3. copy a torrent to Autoload directory