[bug][fixed]Deluge develop Web UI issue

Suggestions and discussion of future versions
Cas
Top Bloke
Top Bloke
Posts: 3679
Joined: Mon Dec 07, 2009 6:04 am
Location: Scotland

Re: Deluge develop 972648 Web UI issue

Post by Cas »

Thanks for tracking that down, I thought I had accounted for that in the new script but maybe forgot... some sorting into alphabetically order should fix it:

Code: Select all

for root, dirnames, filenames in os.walk(SOURCE_DIR):
+    dirnames.sort()
+    filenames.sort()
     for filename in fnmatch.filter(filenames, '*.js'):
alllexx
Member
Member
Posts: 30
Joined: Sat May 23, 2015 1:30 pm

Re: Deluge develop 972648 Web UI issue

Post by alllexx »

Unfortunately, simply sorting sources alphabetically doesn't work. I get this error after using modified script:

Code: Select all

Uncaught TypeError: Cannot read property 'prototype' of undefined @ ext-base.js:7
The order in which '?dev=true' index includes '.js' files isn't alphabetical. I don't know how exactly it is generated, but after concatenating in the exactly the same order and compressing (see my previous post), web ui works fine. While adding sorting lines in the minifier script yields the error above :(
Cas
Top Bloke
Top Bloke
Posts: 3679
Joined: Mon Dec 07, 2009 6:04 am
Location: Scotland

Re: Deluge develop 972648 Web UI issue

Post by Cas »

Ok I'll look into it properly later :D
alllexx
Member
Member
Posts: 30
Joined: Sat May 23, 2015 1:30 pm

Re: Deluge develop 972648 Web UI issue

Post by alllexx »

OK, take your time, thanks :)
Cas
Top Bloke
Top Bloke
Posts: 3679
Joined: Mon Dec 07, 2009 6:04 am
Location: Scotland

Re: Deluge develop 972648 Web UI issue

Post by Cas »

alllexx
Member
Member
Posts: 30
Joined: Sat May 23, 2015 1:30 pm

Re: Deluge develop 972648 Web UI issue

Post by alllexx »

Great, thanks! I'll try this when I get home (after August 22nd)
alllexx
Member
Member
Posts: 30
Joined: Sat May 23, 2015 1:30 pm

Re: Deluge develop 972648 Web UI issue

Post by alllexx »

Tested it and it works fine! Thanks! :)
Post Reply