Connection Manager Behaviour

[etchasketcher]

Hi,

I would like to suggest two changes to the Connection Manager:

- Increase the delay to update the daemons list after starting a daemon through the Connection Manager: maybe my machine is simply a piece of junk, but when I start the local daemon I always have to wait a couple of seconds and push "Refresh" before being able to conect to it (this is on Debian, from Wheezy up to Stretch, deluge 1.3.x upwards);

- Not close the Connection Manager dialog after stopping the daemon I'm connected to through the Connection Manager: if I stop the daemon I'm connected to it's because I'll either connect to a different one or close the client altogether -- there's not much to do without being connected to one. In the latter case, I should just use "File -> Quit and Shutdown Daemon".


I'm using something like this:

Code: Select all

--- a/deluge/ui/gtkui/connectionmanager.py
+++ b/deluge/ui/gtkui/connectionmanager.py
@@ -106,13 +106,13 @@ def start(self):
         pass
 
     def stop(self):
+        pass
+
+    def shutdown(self):
         # Close this dialog when we are shutting down
         if self.running:
             self.connection_manager.response(gtk.RESPONSE_CLOSE)
 
-    def shutdown(self):
-        pass
-
     # Public methods
     def show(self):
         """
@@ -570,6 +570,7 @@ def on_connect(d, c):
         elif status == "Offline":
             self.start_daemon(port, deluge.configmanager.get_config_dir())
             reactor.callLater(0.8, self.__update_list)
+            reactor.callLater(1.6, self.__update_list)
 
     def on_button_refresh_clicked(self, widget):
         self.__update_list()

I consider both to be bugfixes or, at the very least, feature requests, but I couldn't register on the bug tracker (it thinks I'm a robot, and the captcha always fails). If someone manages to create the issue, I wouldn't mind (much) going through the usual fork/commit/rebase/pull hassle on github.

Thoughts? Insults? Indifference?

Cheers.