Page 1 of 1

[Solved] Deluge 1.3.14 broken something Transdroid depends on

Posted: Mon Mar 06, 2017 7:24 pm
by Pyrrhic
Hi,

I upgraded my Deluge 1.3.13 install to 1.3.14 today, and ever since I've been unable to connect to the server through the android app Transdroid.

My system is configured using a reverse proxy as outlined in this guide:

http://www.htpcguides.com/configure-del ... inx-linux/

I saw in the change notes for 1.3.14 that some sort of potential security issue was fixed with the webui - is it possible that in doing so something broke functionality that Transdroid depends on?

Thanks!

EDIT: apologies, wrote in haste - I'm running Ubuntu Mate 16.04 LTS, and installing from the official Deluge PPA.

Re: Deluge 1.3.14 may have broken something Transdroid depends on?

Posted: Mon Mar 06, 2017 10:47 pm
by Cas
It could well be, test reverting the change to the webui python file:

http://git.deluge-torrent.org/deluge/co ... 64a108d583

That change certainly won't be reverted but may review cross-domain in future for develop.

Re: Deluge 1.3.14 may have broken something Transdroid depends on?

Posted: Mon Mar 06, 2017 10:57 pm
by Pyrrhic
Thanks! Er, that's perhaps a little beyond my experiences to date. Is there an easy way to do that, or do I literally just open up the file and make the change manually?

Re: Deluge 1.3.14 may have broken something Transdroid depends on?

Posted: Mon Mar 06, 2017 11:36 pm
by Cas
Yep deleting those lines is all you need to do. Make a backup first of course to save reinstalling :)

Re: Deluge 1.3.14 may have broken something Transdroid depends on?

Posted: Tue Mar 07, 2017 6:44 am
by Pyrrhic
Thanks Cas - to confirm, I opened up json_api.py in /usr/lib/python2.7/dist-packages/deluge/ui/web (made a backup) and then commented out the lines:

Code: Select all

if request.getHeader('content-type') != 'application/json':
        message = 'Invalid JSON request content-type: %s' % request.getHeader('content-type')
        raise JSONException(message)
I then restarted deluged and deluge-web services using systemd, and sure enough Transdroid immediately sprang back into life. Must be that then!

I don't know if you're already familiar with the folks who make Transdroid (?) I'm clearly not terribly technical, but I'll happily seek them out and report this to them if that'd be helpful. Perhaps it's something they can fix at their end as I'm sure that code must have been added for very good reasons!

Thanks for your help :)

EDIT: went to check out Transdrone on github to see if I could work out how to file a bug report and someone had already done so referencing this very thread. The system works! :D

https://github.com/erickok/transdroid/issues/355

Re: Deluge 1.3.14 may have broken something Transdroid depends on?

Posted: Sat Mar 11, 2017 9:25 am
by Ansem
I have the same problem with transdroid and Torrent Status on Firefox.
Today I'll try this fix.
Since is not that easy, it's not possible to release a new version that will fix this problem? Or it's intended an we should wait for an update of transdroid?

Re: Deluge 1.3.14 may have broken something Transdroid depends on?

Posted: Sat Mar 11, 2017 9:22 pm
by Cas
This is an intentional security fix for Deluge WebUI. It is up to Transdroid to release an update, they technically should have set the json content type in the first place.

Re: Deluge 1.3.14 may have broken something Transdroid depends on?

Posted: Sun Mar 12, 2017 1:33 am
by Ansem
Thanks! I'll wait for their update so :)

Re: Deluge 1.3.14 may have broken something Transdroid depends on?

Posted: Mon Mar 20, 2017 9:03 am
by Pyrrhic
Just to confirm all that this issue is now fixed as of Transdroid version 2.5.8, available from the website http://transdroid.org/latest