Improve detection of Visual C++ 2008 Redistributable

Specific support for Deluge on Microsoft Windows OS
Post Reply
lunch
New User
New User
Posts: 5
Joined: Sun Nov 01, 2015 1:52 am

Improve detection of Visual C++ 2008 Redistributable

Post by lunch »

Currently the installer doesn't check for the latest versions of Visual C++ 2008 Redistributable.
As a result, if the user has the latest version of these runtimes installed, it isn't recognized and he is prompted to install these. As more, an older version.

Relevant file: deluge-win32-installer.nsi

CLSID currently checked:
  • FF66E9F6-83E7-3A3E-AF14-8DE9A809A6A4
  • 9A25302D-30C0-39D9-BD6F-21E6EC160475
You should add these two entries:
  • 1F1C2DFC-2D24-3E06-BCB8-725134ADF989
  • 9BE518E6-ECC6-35A9-88E4-87755C07200F
I think you should also remove FF66E9F6-83E7-3A3E-AF14-8DE9A809A6A4, so the user would be prompted to update its antiquated VC++ 2008 redistributable to at least SP1.

Lastly, I would update the download link to https://www.microsoft.com/en-us/downloa ... x?id=26368 in order to direct to the latest version.

References:
Cas
Top Bloke
Top Bloke
Posts: 3679
Joined: Mon Dec 07, 2009 6:04 am
Location: Scotland

Re: Improve detection of Visual C++ 2008 Redistributable

Post by Cas »

Thanks didn't know about that security update, I'll just update the SP1 CLSID for latest security update. I know there is mention that the SP1 redist version can have problems with python, Deluge looks to be fine but rather err on side of caution and leave non-SP1 check in there.

http://dev.deluge-torrent.org/ticket/2777#ticket
lunch
New User
New User
Posts: 5
Joined: Sun Nov 01, 2015 1:52 am

Re: Improve detection of Visual C++ 2008 Redistributable

Post by lunch »

Ouch, I wasn't aware of this version issue...

Some links: I had a quick look at deluge.exe and python27.dll's manifests, it's 9.0.21022.8.

So to be on the safe side, maybe we should check only for non-SP1 runtime and install this version if absent?
Post Reply